Skip to content

fix(sdui): a kind:'html' page can use lazily-registered blocks, and recovers when one registers late - #2988

Merged
os-zhuang merged 1 commit into
mainfrom
claude/react-lazy-block-scope-bpvef6
Jul 30, 2026
Merged

fix(sdui): a kind:'html' page can use lazily-registered blocks, and recovers when one registers late#2988
os-zhuang merged 1 commit into
mainfrom
claude/react-lazy-block-scope-bpvef6

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

#2953 had a twin one tier over, unreported. Found by checking whether the kind:'html' path shared the root cause — it does, with a worse blast radius.

Measured, not inferred

A probe rendering <flex><object-kanban object="showcase_project" /></flex> as a kind:'html' page, with object-kanban registered lazily (exactly how apps/console registers it):

BEFORE_LOAD >>> HTML page failed to compile (2)
                <object-kanban> is not an allowed component
                <object-kanban> is not a known component
AFTER_LOAD  >>> HTML page failed to compile (2)      ← after the loader resolved
KANBAN_RENDERED >>> false

Root cause, and why it's worse here

getJsxManifest() built the whitelist from getAllTypes() + getConfig() — both loaded-only, same as #2953. So a registerLazy()'d block was rejected as unknown, load-order dependently.

Two things make this worse than the react tier:

  1. The whole page dies, not one block. A compile diagnostic fails the page, so one <object-kanban> anywhere in the source replaced everything with an error panel — the <flex> wrapper included. In the react tier a missing block cost one identifier.
  2. It never recovered. layoutElement was memoised on [schema, pageType] with no registry signal, so the cached error panel outlived the plugin actually landing. Broken for the rest of the session.

Also spotted on the way: getJsxManifest()'s cache key was the type count. One registration plus one unregistration leaves the count untouched while the set changed.

The fix

Three lazy-aware reads on ComponentRegistry:

Method Answers
getKnownTypes() "what does this app know about" — loaded plus pending stubs, deduped. What a whitelist or manifest should be built from.
getMeta(type, ns?) metadata from the loaded registration, else from a pending stub.
getVersion() monotonic counter of changes to the known set (register / unregister / registerLazy) — a cache key a count can't substitute for.

getAllTypes() and getConfig() keep their loaded-only meaning ("what can render right now" / "can I render this") and now document it — getConfig()'s callers read .component off it, and a stub has none.

getJsxManifest() builds from the new reads; PageRenderer subscribes to the registry so a page that could not compile retries when the registry grows. Only the kind:'html' branch acts on that tick — every other branch rebuilds the same element type with the same props, which React reconciles in place, as react-page-state.test.tsx (#2984) pins.

On the strictness tradeoff

A stub has no inputs yet, so its props surface as unknown-prop warnings rather than errors: the page compiles and renders, and the inner SchemaRenderer triggers the loader and swaps in the real block.

That is the same call made in #2979 for the manifest generators, pointing the other way — and deliberately so. The runtime whitelist should be permissive, because the alternative is the whole page failing over a block that is genuinely part of the app. The build-time artifact must be strict, and assertFullyLoaded enforces that sdui.manifest.json is generated with every plugin eagerly loaded. So authoring-time prop validation keeps its full inputs; only the in-browser render path relaxes.

Tests

  • lazy block no longer takes the page down;
  • a late registration recovers the page;
  • negative control: a tag nothing has registered is still rejected. Admitting stubs must not turn the whitelist into "anything goes" — that whitelist is what keeps a parsed page from rendering arbitrary tags.

The first two fail against the old page.tsx; the control passes throughout. Plus 6 unit tests for the new registry reads, including that getVersion() moves where a count would not.

Verification

  • Full suite: 701 files passed | 1 skipped, 8234 tests passed | 24 skipped.
  • turbo run type-check: 76/76.
  • lint on core / components: 0 errors.
  • changeset:check: clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp


Generated by Claude Code

…ecovers when one registers late

objectui#2953 had a twin one tier over, unreported. The whitelist a kind:'html'
page's source compiles against was built from `getAllTypes()` + `getConfig()` —
both loaded-only — so any block registered via `registerLazy()` was rejected as
"not an allowed component".

The blast radius is worse than the react tier's. There a missing block cost one
identifier; here a compile diagnostic fails the WHOLE page, so a single
`<object-kanban>` replaced the entire page with "HTML page failed to compile (2)",
`<flex>` wrapper included. And it never recovered: `layoutElement` was memoised
on `[schema, pageType]` with no registry signal, so the cached error panel
outlived the plugin landing — broken for the rest of the session. Measured, not
inferred: a probe rendering that page showed the same panel before and after the
loader resolved.

ComponentRegistry gains three lazy-aware reads:

- `getKnownTypes()` — loaded registrations PLUS pending lazy stubs, deduped; the
  set a whitelist or manifest should be built from. `getAllTypes()` keeps its
  loaded-only meaning ("what can render right now") and now documents it.
- `getMeta(type, namespace?)` — metadata from the loaded registration, else from
  a pending stub. `getConfig()` stays loaded-only, since callers read
  `.component` off it.
- `getVersion()` — monotonic counter of changes to the known set, bumped on
  register / unregister / registerLazy. The previous cache key was the type
  COUNT, which one registration plus one unregistration leaves untouched while
  the set changed.

`getJsxManifest()` builds from those; `PageRenderer` subscribes to the registry
so a page that could not compile retries when the registry grows. Only the
kind:'html' branch acts on that tick — every other branch rebuilds the same
element type with the same props, which React reconciles in place, as
react-page-state.test.tsx pins.

A stub carries no `inputs` yet, so its props surface as `unknown-prop` warnings
rather than errors: the page compiles and renders, and the inner SchemaRenderer
triggers the loader and swaps in the real block. Authoring-time prop validation
is unaffected — sdui.manifest.json is generated with every plugin eagerly loaded
and asserts as much (#2979), so the runtime whitelist being permissive and the
build-time artifact being strict stay deliberate, not accidental.

Tests: lazy block no longer takes the page down, a late registration recovers
(both fail against the old page.tsx), and a tag nothing registered is still
rejected — admitting stubs must not turn the whitelist into "anything goes",
since that whitelist is what keeps a parsed page from rendering arbitrary tags.
Plus 6 unit tests for the new registry reads.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 30, 2026 7:34am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-CpKiVcYO.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.83KB 98.17KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 134.67KB 34.24KB
fields (index.js) 221.10KB 54.18KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 57.26KB 16.24KB
plugin-chatbot (index.js) 179.93KB 42.67KB
plugin-dashboard (index.js) 109.60KB 28.33KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 216.52KB 53.02KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.45KB 25.12KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 179.45KB 47.03KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.30KB 23.23KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.77KB 10.00KB
plugin-timeline (index.js) 25.03KB 7.11KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.47KB 20.82KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.92KB 0.93KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 30, 2026 07:46
@os-zhuang
os-zhuang merged commit 02aef0c into main Jul 30, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/react-lazy-block-scope-bpvef6 branch July 30, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants